https://gitlab.synchro.net/main/sbbs/-/commit/933e8499ac81251da7929f16
Modified Files:
src/encode/uucode.c src/sbbs3/ftpsrvr.cpp mailsrvr.cpp msgdate.c netmail.cpp qwk.cpp qwknodes.c qwktomsg.cpp
Log Message:
Don't treat non-ASCII chars as control chars or white-space
Where plain char is signed (Windows, x86), a "<= ' '" comparison is also
true of every byte with the high bit set, so:
- sockmimetext() trimmed trailing non-ASCII chars (e.g. the last UTF-8
sequence) from each line of a sent message body, along with the CR and
spaces it meant to trim. From e90520e4650 (2012-10-24).
- A received mail header line beginning with a non-ASCII char was treated
as a folded header. From 729eb16b838 (2009-10-21) and e16ff287e66
(2003-03-10).
- Trailing non-ASCII chars were trimmed from an imported QWK message's
tail. From 949b7fac7b2 (2004-05-30).
- The FTP server's dotname() replaced non-ASCII chars with '.' or '_'.
From 7e3e47141a5 (2000-10-10).
- Leading non-ASCII chars were skipped as though white-space when parsing
an RFC822 date (d2f8adcef30, 2003-08-30), FTN netmail kludge lines
(cf57583695c, 2020-04-23), a QWK route (949b7fac7b2, 2004-05-30), a
qwknodes tagline (bac24478c9a, 2005-09-10) and a uudecode file name
(2dd9f388632, 2003-04-22).
The comparisons are now made as unsigned, or replaced with SKIP_WHITESPACE()/isspace(), so the behavior no longer varies with the signedness of plain char. The white-space skips no longer skip other
control chars, and SKIP_WHITESPACE() does skip a CP437 no-break space
(0xFF).
Only compile-checked, with GCC, using both -fsigned-char and
-funsigned-char.
Co-Authored-By: Claude Fable 5.2 <
noreply@anthropic.com>