• 3rdp/build/Common.gmake s

    From Rob Swindell (on Debian L@VERT to Git commit to main/sbbs/m on Fri Nov 20 15:57:00 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/650d06cd655c07f1f4dad696
    Modified Files:
    3rdp/build/Common.gmake src/sbbs3/CMakeLists.txt sbbs.h
    Log Message:
    Build with a stock SpiderMonkey again: fall back to JS_ExecuteScript()

    92e457aa3f (gratis-3-earnings, 2026-11-20) calls
    JS_ExecuteScriptInScope(), which a patch adds to the SpiderMonkey
    source built from 3rdp. Every build that uses another SpiderMonkey
    stopped compiling:

    error C3861: 'JS_ExecuteScriptInScope': identifier not found

    That is the Windows builds, which link the stock SpiderMonkey 1.8.5
    library (it is not going to be patched), and any Unix build given a
    system or other libmozjs185 with JSLIB=, JSINCLUDE= or JSLIBDIR=.

    The build now says when it uses the 3rdp SpiderMonkey: the GNU make
    and CMake builds define SBBS_JS_EXECUTE_SCRIPT_IN_SCOPE there. Without
    it, sbbs.h maps JS_ExecuteScriptInScope to JS_ExecuteScript(), which is
    what every one of those call sites used until that commit. The scope
    problem that commit fixes (#1372) therefore remains in such builds.

    Checked: the define is in JS_CFLAGS for the default GNU make build and
    absent with each of JSLIB=, JSINCLUDE= and JSLIBDIR=; the mapping
    compiles on a small file without the define. Not compiled with MSVC,
    and the CMake change has not been run.

    Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>