• New Defects reported by C

    From scan-admin@coverity.com@VERT to All on Mon Oct 26 12:49:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    5 new defect(s) introduced to Synchronet found with Coverity Scan.
    3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 5 of 5 defect(s)


    ** CID 661079: Error handling issues (CHECKED_RETURN)
    /pack_rep.cpp: 114 in sbbs_t::pack_rep(unsigned int, unsigned int *)()


    _____________________________________________________________________________________________
    *** CID 661079: Error handling issues (CHECKED_RETURN)
    /pack_rep.cpp: 114 in sbbs_t::pack_rep(unsigned int, unsigned int *)()
    108 fexistcase(str);
    109 if ((hdrs = fopen(str, "a")) == NULL)
    110 errormsg(WHERE, ERR_CREATE, str, 0);
    111 }
    112 if (!(cfg.qhub[hubnum]->misc & QHUB_NOVOTING)) {
    113 SAFEPRINTF(str, "%sVOTING.DAT", cfg.temp_dir);
    CID 661079: Error handling issues (CHECKED_RETURN)
    Calling "fexistcase" without checking return value (as is done elsewhere 126 out of 136 times).
    114 fexistcase(str);
    115 if ((voting = fopen(str, "a")) == NULL)
    116 errormsg(WHERE, ERR_CREATE, str, 0);
    117 }
    118 /*********************/
    119 /* Pack new messages */

    ** CID 661078: (Y2K38_SAFETY)
    /pack_qwk.cpp: 628 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    /pack_qwk.cpp: 146 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    /pack_qwk.cpp: 623 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()


    _____________________________________________________________________________________________
    *** CID 661078: (Y2K38_SAFETY)
    /pack_qwk.cpp: 628 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    622 , tmp
    623 , (uint)elapsed
    624 , (uint64_t)((*msgcnt) + mailmsgs) / elapsed);
    625 lprintf(LOG_INFO, "packed %u messages (%s bytes) in %u seconds (%u msgs/sec)"
    626 , (*msgcnt) + mailmsgs
    627 , tmp
    CID 661078: (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "elapsed" is cast to "uint".
    628 , (uint)elapsed
    629 , (uint)(((*msgcnt) + mailmsgs) / elapsed)); 630 }
    631
    632 BOOL voting_data = FALSE;
    633 if (!fclose_checked(qwk)) {
    /pack_qwk.cpp: 146 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    140 return false;
    141 }
    142
    143 now = time(NULL);
    144 if (localtime_r(&now, &tm) == NULL) {
    145 fclose(stream);
    CID 661078: (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "this->now" is cast to "uint".
    146 errormsg(WHERE, ERR_CHK, "time", (uint)now); 147 return false;
    148 }
    149
    150 fprintf(stream, "%s\r\n%s\r\n%s\r\n%s, Sysop\r\n0000,%s\r\n"
    151 "%02u-%02u-%u,%02u:%02u:%02u\r\n" /pack_qwk.cpp: 623 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    617 byte_estimate_to_str(ftell(qwk), tmp, sizeof(tmp), 1024, 1);
    618 if (online == ON_REMOTE)
    619 bprintf("\r\n\r\n\1n\1hPacked %u messages (%s bytes) in %u seconds "
    620 "(%" PRIu64 " messages/second)."
    621 , (*msgcnt) + mailmsgs
    622 , tmp
    CID 661078: (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "elapsed" is cast to "uint".
    623 , (uint)elapsed
    624 , (uint64_t)((*msgcnt) + mailmsgs) / elapsed);
    625 lprintf(LOG_INFO, "packed %u messages (%s bytes) in %u seconds (%u msgs/sec)"
    626 , (*msgcnt) + mailmsgs
    627 , tmp
    628 , (uint)elapsed

    ** CID 661077: Security best practices violations (TOCTOU)
    /nopen.c: 217 in fmutex_close()


    _____________________________________________________________________________________________
    *** CID 661077: Security best practices violations (TOCTOU)
    /nopen.c: 217 in fmutex_close()
    211 #if !defined _WIN32 // should only be necessary (and possible) on *nix 212 // Remove before close, and only the file we opened: once our lock aged out and
    213 // was taken over, the file by this name is the new holder's 214 if (fstat(fm->fd, &fd_st) != 0) {
    215 error = errno;
    216 result = false;
    CID 661077: Security best practices violations (TOCTOU)
    Calling function "stat" to perform check on "fm->name".
    217 } else if (stat(fm->name, &name_st) != 0) {
    218 if (errno != ENOENT) {
    219 error = errno;
    220 result = false;
    221 }
    222 } else if (fd_st.st_dev == name_st.st_dev && fd_st.st_ino == name_st.st_ino) {

    ** CID 661076: (CHECKED_RETURN)
    /qwkjob.cpp: 412 in qwkjob_pack_locked(sbbs_t *, const qwkjob_host *, unsigned int, unsigned int *, char *, unsigned long)()
    /qwkjob.cpp: 397 in qwkjob_pack_locked(sbbs_t *, const qwkjob_host *, unsigned int, unsigned int *, char *, unsigned long)()


    _____________________________________________________________________________________________
    *** CID 661076: (CHECKED_RETURN)
    /qwkjob.cpp: 412 in qwkjob_pack_locked(sbbs_t *, const qwkjob_host *, unsigned int, unsigned int *, char *, unsigned long)()
    406 if (!qwkjob_replace_file(tmppath, qwkpath)) {
    407 #ifdef _WIN32
    408 sbbs->lprintf(LOG_ERR, "!ERROR (WinError %u) renaming %s to %s", (uint)GetLastError(), tmppath, qwkpath);
    409 #else
    410 sbbs->lprintf(LOG_ERR, "!ERROR %d (%s) renaming %s to %s", errno, strerror(errno), tmppath, qwkpath);
    411 #endif
    CID 661076: (CHECKED_RETURN)
    Calling "remove(tmppath)" without checking return value. This library function may fail and return an error code.
    412 remove(tmppath);
    413 return QWKJOB_FAILED;
    414 }
    415 sbbs->lprintf(LOG_INFO, "Packing completed: %s", qwkpath);
    416 sbbs->qwk_success(count, 0, /* prepack: */ 1);
    417 sbbs->putmsgptrs();
    /qwkjob.cpp: 397 in qwkjob_pack_locked(sbbs_t *, const qwkjob_host *, unsigned int, unsigned int *, char *, unsigned long)()
    391 if (qwkjob_terminated(host))
    392 return QWKJOB_FAILED;
    393 sbbs->lprintf(LOG_INFO, "Packing QWK Message Packet");
    394 SAFEPRINTF4(tmppath, "%sfile/%04u.%s.%d.qwk.tmp", sbbs->cfg.data_dir, usernum, qwkjob_local_host_name(), (int)getpid());
    395 SAFEPRINTF2(qwkpath, "%sfile/%04u.qwk", sbbs->cfg.data_dir, usernum);
    396 if (!sbbs->pack_qwk(tmppath, &count, /* prepack: */ true, &reason)) {
    CID 661076: (CHECKED_RETURN)
    Calling "remove(tmppath)" without checking return value. This library function may fail and return an error code.
    397 remove(tmppath);
    398 if (reason == QWKJOB_EMPTY)
    399 sbbs->lputs(LOG_INFO, "No packet created (no new messages)");
    400 return reason;
    401 }
    402 if (qwkjob_terminated(host)) {

    ** CID 661075: Incorrect expression (EVALUATION_ORDER)
    /pack_qwk.cpp: 798 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()


    _____________________________________________________________________________________________
    *** CID 661075: Incorrect expression (EVALUATION_ORDER)
    /pack_qwk.cpp: 798 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    792 lprintf(LOG_ERR, "libarchive error (%s) creating %s", error, packet);
    793 else
    794 lprintf(LOG_INFO, "libarchive created %s from %d files", packet, file_count);
    795 }
    796 if (flength(packet) < 1) {
    797 remove(packet);
    CID 661075: Incorrect expression (EVALUATION_ORDER)
    In argument #1 of "this->cmdstr(this->temp_cmd(ex), packet, path, NULL, ex)", a call is made to "this->temp_cmd(ex)". In argument #1 of this function, the object "ex" is modified. This object is also used in "ex", the argument #5 of the outer function call. The order in which these arguments are evaluated is not specified, and will vary between platforms.
    798 cmdstr(temp_cmd(ex), packet, path, NULL, ex);
    799 if ((i = external(cmdstr_output, ex | EX_WILDCARD)) != 0)
    800 errormsg(WHERE, ERR_EXEC, cmdstr_output, i); 801 if (flength(packet) < 1) {
    802 bputs(text[QWKCompressionFailed]);
    803 return false;


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Tue Oct 27 12:48:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    2 new defect(s) introduced to Synchronet found with Coverity Scan.
    4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 2 of 2 defect(s)


    ** CID 661198: Error handling issues (CHECKED_RETURN)
    /pack_qwk.cpp: 660 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()


    _____________________________________________________________________________________________
    *** CID 661198: Error handling issues (CHECKED_RETURN)
    /pack_qwk.cpp: 660 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    654 SAFEPRINTF(str, "%sPERSONAL.NDX", cfg.temp_dir);
    655 if (!fclose_checked(personal)) {
    656 errormsg(WHERE, ERR_WRITE, str, 0);
    657 write_error = true;
    658 }
    659 if (!flength(str))
    CID 661198: Error handling issues (CHECKED_RETURN)
    Calling "remove(str)" without checking return value. This library function may fail and return an error code.
    660 remove(str);
    661 }
    662 term->newline();
    663
    664 // #1244
    665 SAFEPRINTF(str, "%sMESSAGES.DAT", cfg.temp_dir);

    ** CID 661197: Insecure data handling (INTEGER_OVERFLOW)
    /userdat.c: 1982 in finduserstr()


    _____________________________________________________________________________________________
    *** CID 661197: Insecure data handling (INTEGER_OVERFLOW)
    /userdat.c: 1982 in finduserstr()
    1976 overlapping a record another process holds locked fails; any record
    1977 not read in bulk is then read singly, taking the lock. */
    1978 size_t want = (size_t)count * USER_RECORD_LINE_LEN; 1979 size_t got = 0;
    1980 if (seekuserdat(file, unum)) {
    1981 while (got < want) {
    CID 661197: Insecure data handling (INTEGER_OVERFLOW)
    "want - got", which might have underflowed, is passed to "read(file, buf + got, want - got)".
    1982 ssize_t rd = read(file, buf + got, want - got);
    1983 if (rd <= 0)
    1984 break;
    1985 got += (size_t)rd;
    1986 }
    1987 }


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Thu Oct 29 13:36:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    4 new defect(s) introduced to Synchronet found with Coverity Scan.
    2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 4 of 4 defect(s)


    ** CID 661304: Concurrent data access violations (MISSING_LOCK) /js_socket.cpp: 374 in do_js_close(JSContext *, js_socket_private_t *, bool)()


    _____________________________________________________________________________________________
    *** CID 661304: Concurrent data access violations (MISSING_LOCK) /js_socket.cpp: 374 in do_js_close(JSContext *, js_socket_private_t *, bool)()
    368
    369 static void do_js_close(JSContext *cx, js_socket_private_t *p, bool finalize)
    370 {
    371 size_t i;
    372
    373 if (p->tls_pending) {
    CID 661304: Concurrent data access violations (MISSING_LOCK) >>> Accessing "p->tls_pending->sock" without holding lock "js_socket_tls_pending.mutex". Elsewhere, "js_socket_tls_pending.sock" is written to with "js_socket_tls_pending.mutex" held 1 out of 1 times.
    374 SOCKET sock = p->tls_pending->sock;
    375 // Cancellation precedes closing the notification endpoint.
    376 js_socket_cancel_tls_private(p);
    377 if (p->js_cb)
    378 remove_js_socket_event(cx, p->js_cb, sock);
    379 }

    ** CID 661303: Insecure data handling (INTEGER_OVERFLOW)
    /userdat.c: 1992 in finduserstr_ex()


    _____________________________________________________________________________________________
    *** CID 661303: Insecure data handling (INTEGER_OVERFLOW)
    /userdat.c: 1992 in finduserstr_ex()
    1986 overlapping a record another process holds locked fails; any record
    1987 not read in bulk is then read singly, taking the lock. */
    1988 size_t want = (size_t)count * USER_RECORD_LINE_LEN; 1989 size_t got = 0;
    1990 if (seekuserdat(file, unum)) {
    1991 while (got < want) {
    CID 661303: Insecure data handling (INTEGER_OVERFLOW)
    "want - got", which might have underflowed, is passed to "read(file, buf + got, want - got)".
    1992 ssize_t rd = read(file, buf + got, want - got);
    1993 if (rd <= 0)
    1994 break;
    1995 got += (size_t)rd;
    1996 }
    1997 }

    ** CID 661302: Error handling issues (CHECKED_RETURN)
    /js_socket.cpp: 2648 in js_socket_tls_thread(void *)()


    _____________________________________________________________________________________________
    *** CID 661302: Error handling issues (CHECKED_RETURN)
    /js_socket.cpp: 2648 in js_socket_tls_thread(void *)()
    2642 if (status == CRYPT_OK && !cancelled)
    2643 status = js_socket_activate_tls(pending->session, true, &pending->cert);
    2644 pthread_mutex_lock(&pending->mutex);
    2645 pending->status = status;
    2646 /* The event endpoint remains open until cancellation has set this flag. */
    2647 if (!pending->cancelled)
    CID 661302: Error handling issues (CHECKED_RETURN)
    Calling "send(pending->notify, "x", 1UL, 0)" without checking return value. This library function may fail and return an error code.
    2648 send(pending->notify, "x", 1, 0);
    2649 pthread_mutex_unlock(&pending->mutex);
    2650 js_socket_complete_tls_worker(pending);
    2651 }
    2652
    2653 JSBool js_socket_finish_tls(JSContext *cx, JSObject *obj)

    ** CID 661301: Concurrent data access violations (MISSING_LOCK) /js_socket.cpp: 2636 in js_socket_tls_thread(void *)()


    _____________________________________________________________________________________________
    *** CID 661301: Concurrent data access violations (MISSING_LOCK) /js_socket.cpp: 2636 in js_socket_tls_thread(void *)()
    2630 static void js_socket_tls_thread(void *arg)
    2631 {
    2632 js_socket_tls_pending *pending = static_cast<js_socket_tls_pending *>(arg);
    2633 SetThreadName("sbbs/jsTLS");
    2634 int status = CRYPT_ERROR_NOTINITED;
    2635 if (ssl_sync(pending->cfg, pending->logger)) {
    CID 661301: Concurrent data access violations (MISSING_LOCK) >>> Accessing "pending->session" without holding lock "js_socket_tls_pending.mutex". Elsewhere, "js_socket_tls_pending.session" is written to with "js_socket_tls_pending.mutex" held 1 out of 1 times.
    2636 status = add_private_key(pending->cfg, pending->logger, pending->session);
    2637 pending->key_added = status == CRYPT_OK;
    2638 }
    2639 pthread_mutex_lock(&pending->mutex);
    2640 bool cancelled = pending->cancelled;
    2641 pthread_mutex_unlock(&pending->mutex);


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


  • From scan-admin@coverity.com@VERT to All on Sun Nov 1 13:49:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    2 new defect(s) introduced to Synchronet found with Coverity Scan.
    2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 2 of 2 defect(s)


    ** CID 661497: (RESOURCE_LEAK)
    /xtrn.cpp: 1996 in sbbs_t::external(const char *, int, const char *, const char *, const char *)()
    /xtrn.cpp: 1996 in sbbs_t::external(const char *, int, const char *, const char *, const char *)()


    _____________________________________________________________________________________________
    *** CID 661497: (RESOURCE_LEAK)
    /xtrn.cpp: 1996 in sbbs_t::external(const char *, int, const char *, const char *, const char *)()
    1990 dup2(fd, STDOUT_FILENO);
    1991 if (!(mode & EX_NOLOG))
    1992 dup2(fd, STDERR_FILENO);
    1993 if (fd > 2)
    1994 close(fd);
    1995 }
    CID 661497: (RESOURCE_LEAK)
    Handle variable "fd" going out of scope leaks the handle.
    1996 }
    1997
    1998 if (mode & EX_BG) /* background execution, detach child */
    1999 {
    2000 if (daemon(TRUE, FALSE) != 0)
    2001 lprintf(LOG_ERR, "!ERROR %d (%s) daemonizing: %s", errno, strerror(errno), argv[0]);
    /xtrn.cpp: 1996 in sbbs_t::external(const char *, int, const char *, const char *, const char *)()
    1990 dup2(fd, STDOUT_FILENO);
    1991 if (!(mode & EX_NOLOG))
    1992 dup2(fd, STDERR_FILENO);
    1993 if (fd > 2)
    1994 close(fd);
    1995 }
    CID 661497: (RESOURCE_LEAK)
    Handle variable "fd" going out of scope leaks the handle.
    1996 }
    1997
    1998 if (mode & EX_BG) /* background execution, detach child */
    1999 {
    2000 if (daemon(TRUE, FALSE) != 0)
    2001 lprintf(LOG_ERR, "!ERROR %d (%s) daemonizing: %s", errno, strerror(errno), argv[0]);

    ** CID 661496: (CHECKED_RETURN)
    /xtrn_sec.cpp: 1369 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int, const xtrn_t *)()
    /xtrn_sec.cpp: 1359 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int, const xtrn_t *)()


    _____________________________________________________________________________________________
    *** CID 661496: (CHECKED_RETURN)
    /xtrn_sec.cpp: 1369 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int, const xtrn_t *)()
    1363 int chmod_result = CHMOD(str, _S_IREAD);
    1364 #else
    1365 int chmod_result = CHMOD(str, S_IRUSR);
    1366 #endif
    1367 if (chmod_result != 0) {
    1368 errormsg(WHERE, ERR_WRITE, str, errno);
    CID 661496: (CHECKED_RETURN)
    Calling "remove(str)" without checking return value. This library function may fail and return an error code.
    1369 remove(str);
    1370 return false;
    1371 }
    1372 }
    1373
    1374 else if (type == XTRN_DOORDROP) { /* DOORDROP.INI 1.0 */ /xtrn_sec.cpp: 1359 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int, const xtrn_t *)()
    1353 }
    1354 bool write_ok = bbsdev_write(fp, lines, sizeof(lines) / sizeof(lines[0]));
    1355 if (fclose(fp) != 0)
    1356 write_ok = false;
    1357 if (!write_ok) {
    1358 errormsg(WHERE, ERR_WRITE, str, 0);
    CID 661496: (CHECKED_RETURN)
    Calling "remove(str)" without checking return value. This library function may fail and return an error code.
    1359 remove(str);
    1360 return false;
    1361 }
    1362 #if defined(_WIN32)
    1363 int chmod_result = CHMOD(str, _S_IREAD);
    1364 #else


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Thu Nov 5 13:47:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 661670: Insecure data handling (INTEGER_OVERFLOW)
    /js_socket.cpp: 1168 in js_socket_finish_connect(JSContext *, js_event_list *, bool)()


    _____________________________________________________________________________________________
    *** CID 661670: Insecure data handling (INTEGER_OVERFLOW) /js_socket.cpp: 1168 in js_socket_finish_connect(JSContext *, js_event_list *, bool)()
    1162 {
    1163 js_socket_private_t *p = (js_socket_private_t *)JS_GetPrivate(cx, event->cx);
    1164 struct js_connect_result result;
    1165 size_t received = 0;
    1166 jsrefcount rc = JS_SUSPENDREQUEST(cx);
    1167 while (received < sizeof result) {
    CID 661670: Insecure data handling (INTEGER_OVERFLOW)
    "8UL - received", which might have underflowed, is passed to "recv(event->data.connect.sv[0], (char *)&result + received, 8UL - received, 0)".
    1168 int rd = recv(event->data.connect.sv[0], (char *)&result + received, sizeof result - received, 0);
    1169 if (rd == SOCKET_ERROR && SOCKET_ERRNO == EINTR)
    1170 continue;
    1171 if (rd <= 0)
    1172 break;
    1173 received += rd;


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


  • From scan-admin@coverity.com@VERT to All on Mon Nov 9 13:48:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 661775: Insecure data handling (TAINTED_SCALAR)


    _____________________________________________________________________________________________
    *** CID 661775: Insecure data handling (TAINTED_SCALAR)
    /str.cpp: 655 in sbbs_t::read_sif_dat(char *, char *)()
    649 return;
    650 }
    651 length = read(file, buf, length);
    652 if (length < 0)
    653 length = 0;
    654 close(file);
    CID 661775: Insecure data handling (TAINTED_SCALAR)
    Passing tainted expression "*buf" to "sof", which uses it as an offset. 655 sof(siffile, buf, length);
    656 free(buf);
    657 }
    658
    659 static bool is_template_char(char ch)
    660 {


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Sat Nov 14 13:47:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 662148: High impact quality (Y2K38_SAFETY)
    /upload.cpp: 69 in sbbs_t::uploadfile(smbmsg_t *, long)()


    _____________________________________________________________________________________________
    *** CID 662148: High impact quality (Y2K38_SAFETY)
    /upload.cpp: 69 in sbbs_t::uploadfile(smbmsg_t *, long)()
    63 bprintf(text[FileNotReceived], f->name);
    64 llprintf(LOG_NOTICE, "U!", "attempted to upload %s to %s %s (Not received)"
    65 , f->name
    66 , cfg.lib[cfg.dir[f->dir]->lib]->sname, cfg.dir[f->dir]->sname);
    67 return false;
    68 }
    CID 662148: High impact quality (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "fdate(path)" is cast to "uint32_t".
    69 f->hdr.when_written.time = (uint32_t)fdate(path);
    70 for (i = 0; i < cfg.total_ftests; i++)
    71 if (file_type_match(f->name, cfg.ftest[i]->ext)) {
    72 if (!chk_ar(cfg.ftest[i]->ar, &useron, &client))
    73 continue;
    74 attr(LIGHTGRAY);


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


  • From scan-admin@coverity.com@VERT to All on Tue Nov 17 13:48:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 662206: Error handling issues (CHECKED_RETURN)
    /js_file.cpp: 2457 in js_file_set(JSContext *, JSObject *, long, int, unsigned long *)()


    _____________________________________________________________________________________________
    *** CID 662206: Error handling issues (CHECKED_RETURN)
    /js_file.cpp: 2457 in js_file_set(JSContext *, JSObject *, long, int, unsigned long *)()
    2451 jsdouble pos;
    2452 if (!JS_ValueToNumber(cx, *vp, &pos)) 2453 return JS_FALSE;
    2454 if (!(pos >= 0))
    2455 pos = 0;
    2456 rc = JS_SUSPENDREQUEST(cx);
    CID 662206: Error handling issues (CHECKED_RETURN)
    Calling "fseeko(p->fp, (off_t)pos, 0)" without checking return value. This library function may fail and return an error code.
    2457 fseeko(p->fp, (off_t)pos, SEEK_SET); 2458 JS_RESUMEREQUEST(cx, rc);
    2459 }
    2460 break;
    2461 case FILE_PROP_DATE:
    2462 if (!JS_ValueToECMAUint32(cx, *vp, &u))


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Sat Nov 21 13:47:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 662403: Incorrect expression (SIZEOF_MISMATCH)
    /scfglib1.c: 553 in read_domains_cfg_file()


    _____________________________________________________________________________________________
    *** CID 662403: Incorrect expression (SIZEOF_MISMATCH)
    /scfglib1.c: 553 in read_domains_cfg_file()
    547
    548 SAFEPRINTF2(path, "%s%s", cfg->ctrl_dir, fname);
    549 if ((fp = fnopen(NULL, path, O_RDONLY)) == NULL)
    550 return true;
    551 if ((names = strListInit()) == NULL) {
    552 fclose(fp);
    CID 662403: Incorrect expression (SIZEOF_MISMATCH)
    Passing argument "error" of type "char *" and argument "8UL /* sizeof (char *) */" to function "allocerr" is suspicious.
    553 return allocerr(error, maxerrlen, fname, "domain list", sizeof(char*));
    554 }
    555 while (fgets(line, sizeof line, fp) != NULL) {
    556 if (++lines > DOMAINS_CFG_MAX_LINES) {
    557 snprintf(error, maxerrlen, "%s: only the first %d lines were read", path, DOMAINS_CFG_MAX_LINES);
    558 break;


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview